HexBrain

Brave Software · Report #377206

`settingcontent-ms` files lacks "mark of the web" => execute code by dbl click in Downloads toolbar

Informativestatus
lowseverity
5upvotes
4 Oct 2018disclosed

How it was found

Summary:

settingcontent-ms files allow launching any binary with any params. Brave doesn't mark settingcontent-ms files with "mark of the web", so the file could be executed by double click in "Downloads" toolbar. Launched settingcontent-ms file could lead to code execution with user-level privileges.

Products affected:

Brave: 0.23.19 Muon: 7.1.3 OS: 10.0.17134 (the image was downloaded today from the MS virtualbox images page) Chromium: 67.0.3396

Steps To Reproduce:

  1. Download twitter.settingcontent-ms from attachments.
  2. Dbl click on the item in "Downloads" toolbar.
  3. Calculator opens (but as I said, it's possible to launch anything).

PoC/Screencast additionally leverages #375259.

Supporting Material/References:

  1. FF patched this somewhere between 60-62 version
  2. This bug still works in Edge. As far as I know, that's 1-day.
  3. Chrome downloads settingcontent-ms files only after a confirmation from the user.
  4. This problem is already popular, so you could easily find more info.

PoC + screencast attached. Live PoC: (not sure that it works, it'd be better to test it locally)

Impact

Launched settingcontent-ms could lead to code execution with user-level privileges. Marked as "high", because it's a native OS feature, all Win users are affected.

This report was disclosed publicly on HackerOne and belongs to its author and the program. See the original